Skip to content

Commit

Permalink
Mark pipelineRef.bundle and taskRef.bundle as deprecated in favor of …
Browse files Browse the repository at this point in the history
…bundles resolver

Fixes tektoncd#5514

Signed-off-by: Andrew Bayer <[email protected]>
  • Loading branch information
abayer committed Oct 18, 2022
1 parent ac8da46 commit 08cab15
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 8 deletions.
3 changes: 2 additions & 1 deletion docs/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ being deprecated.
| [The `PipelineRun.Status.TaskRuns` and `PipelineRun.Status.Runs` fields are deprecated and will be removed.](https://github.com/tektoncd/community/blob/main/teps/0100-embedded-taskruns-and-runs-status-in-pipelineruns.md) | v0.35.0 | Beta | Jan 25, 2023 |
| [PipelineRun.Timeout is deprecated and will be removed](https://github.com/tektoncd/community/blob/main/teps/0046-finallytask-execution-post-timeout.md) | v0.36.0 | Beta | Feb 25, 2023 |
| [Several fields of Task.Step are deprecated](https://github.com/tektoncd/pipeline/issues/4737) | v0.36.0 | Beta | Feb 25, 2023 |
| [ClusterTask is deprecated](https://github.com/tektoncd/pipeline/issues/4476) | v0.41.0 | Beta | July 13, 2023 |
| [ClusterTask is deprecated](https://github.com/tektoncd/pipeline/issues/4476) | v0.41.0 | Beta | July 13, 2023 |
| [`pipelineRef.bundle` and `taskRef.bundle` are deprecated](https://github.com/tektoncd/pipeline/issues/5514) | v0.41.0 | Alpha | July 13, 2023 |
8 changes: 5 additions & 3 deletions docs/pipeline-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -6753,7 +6753,7 @@ Resource Types:
<div>
<p>ClusterTask is a Task with a cluster scope. ClusterTasks are used to
represent Tasks that should be publicly addressable from any namespace in the
cluster.</p>
cluster. Deprecated: Please use the cluster resolver instead.</p>
</div>
<table>
<thead>
Expand Down Expand Up @@ -8954,7 +8954,8 @@ string
</td>
<td>
<em>(Optional)</em>
<p>Bundle url reference to a Tekton Bundle.</p>
<p>Bundle url reference to a Tekton Bundle.
Deprecated: Please use ResolverRef with the bundles resolver instead.</p>
</td>
</tr>
<tr>
Expand Down Expand Up @@ -12218,7 +12219,8 @@ string
</td>
<td>
<em>(Optional)</em>
<p>Bundle url reference to a Tekton Bundle.</p>
<p>Bundle url reference to a Tekton Bundle.
Deprecated: Please use ResolverRef with the bundles resolver instead.</p>
</td>
</tr>
<tr>
Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/pipeline/v1beta1/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/apis/pipeline/v1beta1/pipelineref_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ type PipelineRef struct {
// +optional
APIVersion string `json:"apiVersion,omitempty"`
// Bundle url reference to a Tekton Bundle.
// Deprecated: Please use ResolverRef with the bundles resolver instead.
// +optional
Bundle string `json:"bundle,omitempty"`

Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/pipeline/v1beta1/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,7 @@
"type": "string"
},
"bundle": {
"description": "Bundle url reference to a Tekton Bundle.",
"description": "Bundle url reference to a Tekton Bundle. Deprecated: Please use ResolverRef with the bundles resolver instead.",
"type": "string"
},
"name": {
Expand Down Expand Up @@ -2469,7 +2469,7 @@
"type": "string"
},
"bundle": {
"description": "Bundle url reference to a Tekton Bundle.",
"description": "Bundle url reference to a Tekton Bundle. Deprecated: Please use ResolverRef with the bundles resolver instead.",
"type": "string"
},
"kind": {
Expand Down
1 change: 1 addition & 0 deletions pkg/apis/pipeline/v1beta1/taskref_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ type TaskRef struct {
// +optional
APIVersion string `json:"apiVersion,omitempty"`
// Bundle url reference to a Tekton Bundle.
// Deprecated: Please use ResolverRef with the bundles resolver instead.
// +optional
Bundle string `json:"bundle,omitempty"`

Expand Down

0 comments on commit 08cab15

Please sign in to comment.