Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line chart: Metrices and Dimensions, Legend, Chart styles features implementation on config panel #2

Merged
merged 19 commits into from
Jun 24, 2022
Merged

Line chart: Metrices and Dimensions, Legend, Chart styles features implementation on config panel #2

merged 19 commits into from
Jun 24, 2022

Conversation

rinku-kumar-psl
Copy link
Collaborator

Description

[Describe what this change achieves]
The below features are implemented in the config panel in this PR:

Legend:

  • Show Legend
  • Position

Chart styles:

  • Mode (Line, Bars, Points, Lines+Points)
  • Interpolation (Linear, Smooth, Step Before, Step After)
  • Line Width
  • Fill Opacity
  • Point Size

Metrix and dimension UI Integration on Data Configuration.

Issues Resolved

[List any issues this PR will resolve]
opensearch-project#697 opensearch-project/dashboards-observability#125

Here are the visuals and implementation of new Data configs on the Line chart as per the issue opensearch-project#697
opensearch-project#697 (comment)

Check List

  • New functionality includes above listed Legend and Chart styles features in the Data config panel and Metrix and Dimension Integration.
    • All tests that pass, including unit test, and integration test, except a few test cases, are failing at my end which is not related to this functionality.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@spattnaik

@rinku-kumar-psl
graph style section UI schema
ed78cff 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts
@rinku-kumar-psl
changes for style mode and interpolation
5f8ed2b 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts
@rinku-kumar-psl
lineWidth integration for line mode
3da4b49 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_style_slider.tsx
@rinku-kumar-psl
changes for Legend and Orientation in Line
4a4207c 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_legend.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_style_slider.tsx
@rinku-kumar-psl
point size and Bar Alignment changes
790b33b 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
#	dashboards-observability/common/types/explorer.ts
@rinku-kumar-psl
implemented fill opacity for line chart
b5a6191 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx
@rinku-kumar-psl
changes for line width and fill opacity in bar mode and removed mode …
bae6b96 
…from chartOption

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
@rinku-kumar-psl
updated bar mode opacity in line chart
c91c934 
Signed-off-by: rinku-kumar-psl <[email protected]>
@rinku-kumar-psl
refactored the config chart style code
30e7e88 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
#	dashboards-observability/common/types/explorer.ts
@rinku-kumar-psl
snapshot updated and code refactored
6e399da 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx
@rinku-kumar-psl
type added to new component
8235008 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_style_slider.tsx
@rinku-kumar-psl
review comments addressed
68fd32a 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
@rinku-kumar-psl
cypress test case added and resolve button label wraping issue
f2d3d32 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js
#	dashboards-observability/.cypress/utils/event_constants.js

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js
@rinku-kumar-psl
multi matrices changes for Line
a76ac36 
Signed-off-by: rinku-kumar-psl <[email protected]>
@rinku-kumar-psl
dimensions and metrics UI changes for time-series
23373a1 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/common/constants/explorer.ts
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/index.tsx
@rinku-kumar-psl
made data config pannel collapsable and initial fields render
988e761 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/index.tsx
@rinku-kumar-psl
code refactored
2cb28f7 
Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx
@rinku-kumar-psl
snapshot updated and handled corner cases
e632d77 
Signed-off-by: rinku-kumar-psl <[email protected]>
abasatwar
abasatwar requested changes Jun 24, 2022
View reviewed changes
...plorer/visualizations/config_panel/config_panes/config_controls/config_line_chart_styles.tsx
if (!vizState?.style || vizState?.style === "lines") {
return schemas.filter((schema: IConfigPanelOptionSection) => schema.mapTo !== 'pointSize');
}
if (vizState?.style === "bar") {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this in config line chart file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abasatwar, As we can switch Line traces between BAR and LIne, So this check is there.

dashboards-observability/public/components/visualizations/charts/lines/line.tsx Outdated
multiMetrics = {
...multiMetrics,
[`yaxis${index + 1}`]: {
// title: `yaxis${index + 1} title`,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Added TODO comment.

@abasatwar abasatwar self-requested a review June 24, 2022 12:04
abasatwar
abasatwar approved these changes Jun 24, 2022
View reviewed changes
Copy link
Owner

@abasatwar abasatwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@abasatwar abasatwar merged commit af895be into abasatwar:sprint1 Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abasatwar abasatwar abasatwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rinku-kumar-psl @abasatwar