Skip to content

Commit

Permalink
Sprint1 : combine PR for visualization from Sprint1 (opensearch-proje…
Browse files Browse the repository at this point in the history
…ct#824)

* graph style section UI schema

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts

* changes for style mode and interpolation

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

* lineWidth integration for line mode

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_style_slider.tsx

* changes for Legend and Orientation in Line

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_legend.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_style_slider.tsx

* point size and Bar Alignment changes

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx
#	dashboards-observability/public/components/visualizations/charts/lines/line_type.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
#	dashboards-observability/common/types/explorer.ts

* implemented fill opacity for line chart

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/visualizations/charts/lines/line.tsx

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx

* changes for line width and fill opacity in bar mode and removed mode from chartOption

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/common/constants/shared.ts

* updated bar mode opacity in line chart

Signed-off-by: rinku-kumar-psl <[email protected]>

* refactored the config chart style code

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/index.ts

# Conflicts:
#	dashboards-observability/common/constants/shared.ts
#	dashboards-observability/common/types/explorer.ts

* snapshot updated and code refactored

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx

* type added to new component

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_style_slider.tsx

* review comments addressed

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx

# Conflicts:
#	dashboards-observability/common/constants/shared.ts

* cypress test case added and resolve button label wraping issue

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js
#	dashboards-observability/.cypress/utils/event_constants.js

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js

# Conflicts:
#	dashboards-observability/.cypress/integration/1_event_analytics.spec.js

* multi matrices changes for Line

Signed-off-by: rinku-kumar-psl <[email protected]>

* dimensions and metrics UI changes for time-series

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/common/constants/explorer.ts
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/index.tsx

* made data config pannel collapsable and initial fields render

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/index.tsx

* code refactored

Signed-off-by: rinku-kumar-psl <[email protected]>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/data_config_panel_item.tsx

* snapshot updated and handled corner cases

Signed-off-by: rinku-kumar-psl <[email protected]>

* code styling fixes and added TODO comment

Signed-off-by: rinku-kumar-psl <[email protected]>

* table view: eui table replaced with ag-grid

Signed-off-by: Ramneet Chopra <[email protected]>

* drag-drop issue fixed

Signed-off-by: Ramneet Chopra <[email protected]>

* test case of data_table updated

Signed-off-by: Ramneet Chopra <[email protected]>

* feedback comments resolved

Signed-off-by: Ramneet Chopra <[email protected]>

* grid height issue:fixed

Signed-off-by: Ramneet Chopra <[email protected]>

* column height, value getter for type double

Signed-off-by: Ramneet Chopra <[email protected]>

* data_table elements moved to separate

Signed-off-by: Ramneet Chopra <[email protected]>

* footer components

Signed-off-by: Ramneet Chopra <[email protected]>

* cypress test cases for table view

Signed-off-by: Ramneet Chopra <[email protected]>

* data config reviewed code added

Signed-off-by: Deepak Nevde <[email protected]>

* Text correction

Signed-off-by: Deepak Nevde <[email protected]>

* Conflicts resolved

Signed-off-by: Deepak Nevde <[email protected]>

* enhancement for heatmap with new UI

Signed-off-by: Shankha Das <[email protected]>

* line chart test cases

Signed-off-by: Shankha Das <[email protected]>

* console logs removed

Signed-off-by: Shankha Das <[email protected]>

* updated value options ui for treemap

Signed-off-by: Mrunal Zambre <[email protected]>

* removed console

Signed-off-by: Mrunal Zambre <[email protected]>

* sprint1-visualization-fixes.

Signed-off-by: abasatwar <[email protected]>

* initialize default params for DimensonComponent and formatted the codes

Signed-off-by: rinku-kumar-psl <[email protected]>

* code review changes done

Signed-off-by: rinku-kumar-psl <[email protected]>

* added empty line at end.

Signed-off-by: abasatwar <[email protected]>

Co-authored-by: rinku-kumar-psl <[email protected]>
Co-authored-by: Ramneet Chopra <[email protected]>
Co-authored-by: Deepak Nevde <[email protected]>
Co-authored-by: Shankha Das <[email protected]>
Co-authored-by: Mrunal Zambre <[email protected]>
  • Loading branch information
6 people authored Jul 8, 2022
1 parent 4bebc60 commit bf98d97
Show file tree
Hide file tree
Showing 31 changed files with 2,832 additions and 2,051 deletions.
529 changes: 208 additions & 321 deletions dashboards-observability/.cypress/integration/1_event_analytics.spec.js

Large diffs are not rendered by default.

28 changes: 28 additions & 0 deletions dashboards-observability/.cypress/utils/event_constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,31 @@ export const renderPieChart = () => {
cy.get('[data-test-subj="comboBoxToggleListButton"]').eq(0).click();
cy.get('[data-test-subj="comboBoxInput"]').eq(2).click();
};

export const renderDataConfig = () => {
cy.get('.euiResizablePanel.euiResizablePanel--middle').contains('Data Cofigurations');
cy.get('.euiTitle.euiTitle--xxsmall').eq(1).contains('Dimensions').should('exist');
cy.get('.first-division .euiFormLabel.euiFormRow__label').eq(0).contains('Aggregation');
cy.get('[data-test-subj="comboBoxSearchInput"]').eq(0).click();
cy.get('.euiComboBoxOption__content').eq(2).click();
cy.get('.first-division .euiFormLabel.euiFormRow__label').eq(1).contains('Field');
cy.get('[data-test-subj="comboBoxSearchInput"]').eq(1).click();
cy.get('.euiComboBoxOption__content').eq(1).click();
cy.get('.euiFieldText[placeholder="Custom label"]').eq(0).type('Average field');
cy.get('.euiTitle.euiTitle--xxsmall').eq(2).contains('Metrics').should('exist');
cy.get('.first-division .euiFormLabel.euiFormRow__label').eq(0).contains('Aggregation');
cy.get('.euiFormRow__fieldWrapper .euiComboBox').eq(2).click();
cy.get('.euiComboBoxOption__content').eq(4).click();
cy.get('.first-division .euiFormLabel.euiFormRow__label').eq(4).click();
cy.get('.euiComboBoxOption__content').eq(0).click();
cy.get('.euiFieldText[placeholder="Custom label"]').eq(1).type('Min field');
cy.get('.euiButton__text').contains('Right').click();
cy.get('[data-test-subj="visualizeEditorRenderButton"]').contains('Update chart').click();
cy.get('.js-plotly-plot').should('exist');
};

export const renderLineChart = () => {
landOnEventVisualizations();
querySearch(TEST_QUERIES[5].query, TEST_QUERIES[5].dateRangeDOM);
cy.get('[data-test-subj="configPane__vizTypeSelector"] [data-test-subj="comboBoxInput"]').type('Line').type('{enter}');
};
13 changes: 13 additions & 0 deletions dashboards-observability/common/constants/explorer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,3 +117,16 @@ export const AGGREGATION_OPTIONS = [
label: 'STDDEV_POP',
},
];

// Data table constants
export const GRID_HEADER_COLUMN_MAX_WIDTH = '150px';
export const GRID_PAGE_RANGE_DISPLAY = 5;
export const COLUMN_DEFAULT_MIN_WIDTH = 100;
export const GRID_PAGE_SIZES = [10, 50, 100];
export const ROW_DENSITIES = [
{ icon: 'tableDensityExpanded', height: 55, selected: false },
{ icon: 'tableDensityNormal', height: 45, selected: false },
{ icon: 'tableDensityCompact', height: 35, selected: true },
];

export const HEADER_HEIGHT = 35;
14 changes: 14 additions & 0 deletions dashboards-observability/common/types/explorer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -230,3 +230,17 @@ export interface LiveTailProps {
isLiveTailPopoverOpen: boolean;
dataTestSubj: string;
}

export interface ConfigListEntry {
label: string;
aggregation: string;
custom_label: string;
name: string;
side: string;
type: string;
}

export interface ConfigList {
dimensions?: ConfigListEntry[];
metrics?: ConfigListEntry[];
}
3 changes: 3 additions & 0 deletions dashboards-observability/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@
"@nteract/outputs": "^3.0.11",
"@nteract/presentational-components": "^3.4.3",
"@reduxjs/toolkit": "^1.6.1",
"ag-grid-community": "^27.3.0",
"ag-grid-react": "^27.3.0",
"plotly.js-dist": "^2.2.0",
"react-graph-vis": "^1.0.5",
"react-paginate": "^8.1.3",
"react-plotly.js": "^2.5.1"
},
"devDependencies": {
Expand Down
Loading

0 comments on commit bf98d97

Please sign in to comment.