-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use latest vuepress and remove unused features #254
Conversation
redirects are removed |
Hi @Mister-Hope Marc here. I had the same initial reaction to your PR as Lars. It came out of nowhere and has no description at all. This is a very large diff too and I didn't see the redirects either. You have to scroll way down to find them. Like Lars, I would have rejected this. Your account name looks rather anonymous, too. So it's not apparent that you are from the Vue team. Now that I saw your profile the PR makes more sense. Some short description here would have definitely avoided this misunderstanding. I will take a look at this update later in more detail. |
I hate to make huge diffs, but obviously the project haven't maintain deps for quite a long time. Also it might be bothering for both side to make tweaks PRs one by one especially they are relying on the former one. Generally the changes are as follows:
I have some spare time last weekend, so I tried to help upgrading vuepress and my theme in some repos that have much stars.(see my timeline other PRs are made and some of them are already merged). I am sure I am doing everything well, and nothing is dropped without asking. Feel free to have a deep review if you think this is needed though. |
I tested it and technically it works great. Thanks for the migration! There's a small issue with the red theme color. It used to render as You already have Before: After: |
The color is meant to fix the background/text contrast, so we made a update for this, technically now a set of theme colors are automatically generated from the given theme color to ensure visual-inspired people can read the text clearly. For the action button and the link text color, the original color does not fit this: Users can still override them in palette file, I can update this now, but I need you to confirm this first. @mbtools Since I met some visual-inspired and body-inspired friends while helping people, so VuePress ecosystem are focusing on a11y things. |
Ref: https://dequeuniversity.com/rules/axe/4.9/color-contrast (from lighthouse) |
That makes a lot of sense. I'm all for improving accessibility. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
see comments