feat(Soundboard): Add Soundboard Sound functionality #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is incomplete, comments where relevant
|
Perhaps add a getter for get id() {
return this.soundID;
} |
|
Sure, however that still doesn't solve the main issue of not being able to properly store the data directly into the collection I am discussing this with abal to see what our options are |
bsian03
commented
Sep 25, 2024
| * @arg {String?} [options.emojiName] The name of the relating default emoji (mutually exclusive with options.emojiID) | ||
| * @arg {String} [options.name] The name of the soundboard sound (2-32 characters) | ||
| * @arg {Number?} [options.volume] The volume of the soundboard sound, between 0 and 1 | ||
| * @arg {String} [options.reason] The reason to be displayed in audit logs |
There was a problem hiding this comment.
separate this into its own argument?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Currently there is an incompatibility with storing soundboard sounds in cache, as there is noidin the soundboard sound structure but required in Collection.The PR in it's current state (2024-09-25T03:41Z) will not work, as gateway logic is written as if the collection were to exist#1547 to be folded into this PR once complete