Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: user-installables #1532

Open
wants to merge 43 commits into
base: dev
Choose a base branch
from
Open

feat: user-installables #1532

wants to merge 43 commits into from
+151 −9

Conversation

retrouser955
Copy link

@retrouser955 retrouser955 commented Aug 25, 2024 •
edited
Loading

This pull requests adds the ability to configure application command context which allows the creation of user-installable commands.

@retrouser955 retrouser955 marked this pull request as draft August 25, 2024 07:32
@retrouser955
Copy link
Author

I have not tested this feature yet so the pull request will be a draft for now.

@retrouser955
Copy link
Author

retrouser955 commented Aug 25, 2024 •
edited
Loading

Hey, I just have a couple of questions. Would you add the context of the application command usage CommandInteraction or CommandInteractionData?

Right now, I have it set to the former and I was just checking if changes are needed.
image

Edit: Question answered via Discord

@retrouser955 retrouser955 marked this pull request as ready for review August 25, 2024 15:35
bsian03
bsian03 requested changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@bsian03 bsian03 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please lint.

lib/structures/CommandInteraction.js Outdated Show resolved Hide resolved
babiabeo
babiabeo reviewed Aug 25, 2024
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
bsian03
bsian03 requested changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ApplicationCommand typings. Also when you lint, please use the script provided in package.json

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
examples/userCommand.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/structures/CommandInteraction.js Outdated Show resolved Hide resolved
bsian03
bsian03 requested changes Aug 29, 2024
View reviewed changes
lib/structures/CommandInteraction.js Outdated Show resolved Hide resolved
bsian03
bsian03 requested changes Aug 31, 2024
View reviewed changes
index.d.ts Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
bsian03
bsian03 requested changes Oct 4, 2024
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
lib/structures/AutocompleteInteraction.js Show resolved Hide resolved
@bsian03 bsian03 mentioned this pull request Oct 19, 2024
Open
@bsian03
Copy link
Collaborator

bsian03 commented Oct 19, 2024

Missing authorizing_integration_owners

bsian03
bsian03 requested changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a lot of things in discord/discord-api-docs@1eaa1af that aren't in this pr

@bsian03
Copy link
Collaborator

bsian03 commented Oct 19, 2024

discord/discord-api-docs#6958 may need to be looked at in relation to this as well

@bsian03
Copy link
Collaborator

bsian03 commented Oct 20, 2024

discord/discord-api-docs#7181

@bsian03 bsian03 mentioned this pull request Nov 1, 2024
Open
55 tasks
@retrouser955
Copy link
Author

Oh sorry, I didn't see that USE_EXTERNAL_APPs has been implemented already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babiabeo babiabeo babiabeo left review comments

@bsian03 bsian03 bsian03 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@retrouser955 @bsian03 @babiabeo