Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structs): fix incorrect thread method references #1301

Merged
merged 3 commits into from
Nov 16, 2021
Merged

fix(structs): fix incorrect thread method references #1301

merged 3 commits into from
Nov 16, 2021

Conversation

ZixeSea
Copy link
Contributor

@ZixeSea ZixeSea commented Nov 16, 2021

There were 2 broken methods there instead of this._client it was still using this.client resulting in a "Cannot read property 'methods' of undefined" error

@bsian03 bsian03 changed the title Fixed 2 broken thread methods fix(structures): Fix client reference in methods Nov 16, 2021
@bsian03 bsian03 added the bug label Nov 16, 2021
bsian03
bsian03 previously approved these changes Nov 16, 2021
@bsian03
Copy link
Collaborator

bsian03 commented Nov 16, 2021

Man... find and replace in js do be broke

Seems like there is another problem with the methods "getActiveThreads" in the Guild structure, this uses getActiveThreads (what is used to get all active threads in a channe) and this should be getActiveGuildThreads (what is used to get all active threads in a guild).

getActiveThreads also requires a "channelID" and won't give the expected result
@bsian03 bsian03 changed the title fix(structures): Fix client reference in methods fix(structures): Fix incorrect references in methods Nov 16, 2021
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should really look at these PRs better...

@abalabahaha abalabahaha added this to the 0.16.1 milestone Nov 16, 2021
@abalabahaha abalabahaha changed the title fix(structures): Fix incorrect references in methods fix(structs): fix incorrect method references Nov 16, 2021
@abalabahaha abalabahaha changed the title fix(structs): fix incorrect method references fix(structs): fix incorrect thread method references Nov 16, 2021
@abalabahaha abalabahaha merged commit 87473ba into abalabahaha:dev Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants