Upgrade Remote Pool #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rade-remote-pool-fix
|
miguelmtzinf
approved these changes
Jul 22, 2024
|
After reviewing the changes, the fixes seem ok to me |
|
remove |
miguelmtzinf
added a commit
that referenced
this pull request
Nov 7, 2024
* feat: enable remote rateLimitAdmin * chore: prettier * fix: remove unnecessary modifer * chore: reorder state variables * feat: upgrade remote pool * test: add tests after upgrading * feat: reserve storage space for future upgrades * diff: Update diff for UpgradeableBurnMintTokenPool * ci: Fix ci * ci: Fix ci * test: show init reverting after upgrade * fix: remove gap * fix: return to original test suite * test: simple tests showing upgrade * fix: add and correct comments * fix: comments to match parent contract * chore: prettier * fix: allow calls 1.2 on ramp during 1.5 migration by introducing legacyOnRamp * chore: update certora & compiler used to match forge * test: add fork base * wip: fork upgrade test * fix: onlyOnRamp condition * test: add testnet legacy pools * test: successful send with upgrade * test: add releaseOrMint tests * fix: legacyOnRamp -> proxyPool * feat: set proxy pool only once for dest chain * feat(tokenPools): disableInitializer on constructor, upd docs * fix: revert UpgradeableBurnMintTokenPoolOld from #16 (was accidentally merged) * chore: update diffs * chore: use negative conditional code style * docs: move base contract modification doc * Update contracts/src/v0.8/ccip/test/pools/GHO/fork/GhoTokenPoolMigrate1_4To1_5/ForkBase.t.sol Co-authored-by: miguelmtz <[email protected]> * chore: update diffs * doc: for SendViaLegacyPool test * chore: reorder imports for consistency with code style * fix: rm immutability of pool proxy * test: rename for consistency * fix: use chain agnostic proxypool * fix: import on token pools to match chainlink style convention, upd diff * fix: test renaming to match style convention * chore: fix import order * chore: rm internal inline, typo * test: for 1_2OnRamp, refactor _messageToEvent * chore: rm unsued * doc: rm incorrect comment on proxy pool * test: fork test pre migration setup * test: expect events fork before migration * chore: revert name change in test * chore: upd comment * fix: rm disableInitializer as its handled by Initializable * chore: fix diff using diff algorithm patience * fix: add proxyPool whitelist to onlyOffRamp modifier * test: improve off ramp tests * chore: cleanup imports * test: dynamically fetch dest gas amt * fix: docs --------- Co-authored-by: CheyenneAtapour <[email protected]> Co-authored-by: miguelmtzinf <[email protected]> Co-authored-by: miguelmtz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We show the process of upgrading the old remote pool to the new one, and verify we can set the rateLimitAdmin via simple tests.