Improving skip of updateState() by time, and caching dynamics for indexes #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved caching flow on next_ indexes
eboadom
requested review from
The-3D,
miguelmtzinf,
stevenvaleri,
foodaka,
kartojal,
Zer0dot,
donosonaumczuk and
BenSparksCode
as code owners
kartojal
approved these changes
Nov 2, 2022
Comment on lines
351
to
352
| ) | ||
| .scaledTotalSupply(); |
There was a problem hiding this comment.
I think the way your prettier tooling formatted this two lines are a bit messy for readability.
The .scaledTotalSupply() contains an extra new line and also an extra tab, so is like floating over there.
There was a problem hiding this comment.
I think the issue is on the pre-commit hook because it auto-formats this way even when forcing a different format. Any idea?
miguelmtzinf
approved these changes
Nov 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #723