-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/enable disable flashloan config #710
Changes from 19 commits
bb62572
d7aa26a
348ce20
8b9221b
8d12d79
a5ce86a
4c2cda0
2710b9c
c3c6e75
6f5d692
4fb58e8
a5d188c
c646e35
7d3bedd
c17c5a8
2f2e18e
9d84549
284b492
8888093
748818f
7bd04e7
49d0f4e
516e0e8
81b9cb9
d87efa6
1820962
078fa28
bf652c2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -472,6 +472,7 @@ library ValidationLogic { | |
.configuration; | ||
require(!configuration.getPaused(), Errors.RESERVE_PAUSED); | ||
require(configuration.getActive(), Errors.RESERVE_INACTIVE); | ||
require(configuration.getFlashLoanEnabled(), Errors.FLASHLOAN_DISABLED); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the same require missing in the
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch. Let's add tests and evaluate this change! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed - will update |
||
} | ||
} | ||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless it was previously used for other stuff, ewe can use the reserved 63th bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this bit is reserved for something or has been used previously. @The-3D any insight?