fix: eslint #10
Merged
fix: eslint #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this patch i wasn't able to commit as eslint failes on precommit.
Added the path proposed in jaredpalmer/tsdx#926 (comment) - the other option would have been downgrading ts to 3.x, but I guess it was upgraded on purpose so changing resolutions for lint depenencies seemed like an okayish approach.
you shouldn't mix yarn and npm (at least that's what the console says), so i removed the npm lockfile as tsdx recommends yarn as default afaik