Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting v2 #95

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Linting v2 #95

wants to merge 5 commits into from

Conversation

jfhbrook
Copy link

As promised - #94 with the alias removed. To recap, this:

  • Adds simple directions for using PSScriptAnalyzer for linting
  • Changes a variable name so as to not shadow the automatic $args variable inside a function
  • Adds ShouldProcess support to functions with names that start with Set

I decided to punt on updating the tests to use the latest Pester - this work should probably still be done, but I'd rather not send a PR that half-asses it.

@aaronpowell
Copy link
Owner

Drat, looks like Pester 5 has quite a lot of changes in it that are causing the build to fail.

I'm going to make a change where I pin Pester to v4 for the time being so the PR can be reviewed and separately Pester 5 can be investigated.

@aaronpowell
Copy link
Owner

I've just updated the tests to use Pester 5 and merged that into your branch.

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #95 into master will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   81.36%   81.59%   +0.22%     
==========================================
  Files           2        2              
  Lines         161      163       +2     
==========================================
+ Hits          131      133       +2     
  Misses         30       30              
Impacted Files Coverage Δ
nvm.psm1 82.69% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3503d0...fd6b596. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants