Improve ContainerTypeValidate performance for object types

Use const reference for class name instead of copying, to avoid some extra reference counting overhead
aaronp64 · Dec 5, 2024 · b19ebba · b19ebba
1 parent 1f47e4c
commit b19ebba
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/core/variant/container_type_validate.h b/core/variant/container_type_validate.h
@@ -124,9 +124,9 @@ struct ContainerTypeValidate {
 			return true; // All good, no class type requested.
 		}
 
-		StringName obj_class = object->get_class_name();
+		const StringName &obj_class = object->get_class_name();
 		if (obj_class != class_name) {
-			ERR_FAIL_COND_V_MSG(!ClassDB::is_parent_class(object->get_class_name(), class_name), false, vformat("Attempted to %s an object of type '%s' into a %s, which does not inherit from '%s'.", String(p_operation), object->get_class(), where, String(class_name)));
+			ERR_FAIL_COND_V_MSG(!ClassDB::is_parent_class(obj_class, class_name), false, vformat("Attempted to %s an object of type '%s' into a %s, which does not inherit from '%s'.", String(p_operation), object->get_class(), where, String(class_name)));
 		}
 
 		if (script.is_null()) {