-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC Implementation #18
Open
Copterdoctor
wants to merge
7
commits into
aaronjedwards:master
Choose a base branch
from
Copterdoctor:ja-rpc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for putting this together @Copterdoctor. I haven't had my head in this project for a little while now, but I will take a look at this by the weekend and get it merged. |
Hi all.
Sorry this is a bit cheeky of me, but now having had a bit of time to play a bit more, I have a few requests –
1. Any chance per row we can have a column count visible, and also be able to reference columns by index.
for count in row.Count {
print(“\(row.column[count])”);
}
2. it would also be great to make the tdsData for each row non protected, it would be great to be able to introspect what’s coming back from a query and look at the datatype, size, precision of a column etc.
3. I think this is on your todo list, but order by doesn’t seem to work on queries.
4. Could we have it so we can connect to server via ip address please.
The other thing, that I tried todo was import the package into Swift Playgrounds 4 on an iPad. That doesn’t seem to work it complains about ‘package tags’ missing. How cool would it be, if this could work.
Kind Regards
Richard
Richard Jones | +44 / 0 7795 276690
From: Aaron Edwards ***@***.***>
Sent: 05 April 2022 16:17
To: aaronjedwards/swift-tds ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [aaronjedwards/swift-tds] RPC Implementation (PR #18)
Thanks for putting this together @Copterdoctor <https://github.com/Copterdoctor> . I haven't had my head in this project for a little while now, but I will take a look at this by the weekend and get it merged.
—
Reply to this email directly, view it on GitHub <#18 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2LPUGYUPKBNLY5ASKIOXDVDRKNNANCNFSM5RF5OTKA> .
You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/AB2LPUFOQWH7MNYQSGPOPRTVDRKNNA5CNFSM5RF5OTKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIDTIZVY.gif> Message ID: ***@***.*** ***@***.***> >
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPC functionality including output parameters supported. Tests added and SQL script updated to include mock table and data due to issue found with TDS messages fragmented across multiple TCP packets needing to be reassembled.