Skip to content

Commit

Permalink
When using docker in bridge mode, jupyter notebook 5.5 will report
Browse files Browse the repository at this point in the history
the docker ID as the host name. This will likely confuse users.

jupyter/docker-stacks#642

In future versions of jupyter there will be an option to overide
the hostname. For now fall back to notebook 5.4.

In singularity we continue to use version 5.5
  • Loading branch information
Aard Keimpema committed Jun 26, 2018
1 parent 4d94f49 commit a838adc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ RUN wget http://launchpadlibrarian.net/165141962/libeigen3-dev_3.2.0-8_all.deb \
# install jupyter
RUN apt-get install -y gfortran build-essential python-numpy-dev \
&& pip install --upgrade pip \
&& /usr/local/bin/pip install jupyter
&& /usr/local/bin/pip install "notebook<5.5"

# Dependencies - RPFITS
RUN wget ftp://ftp.atnf.csiro.au/pub/software/rpfits/rpfits-2.24.tar.gz \
Expand Down
3 changes: 3 additions & 0 deletions singularity/Singularity.docker
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ IncludeCmd: no
# Remove Juputer user imported from Docker
sed -i '/jupyter/d' /etc/passwd
sed -i '/jupyter/d' /etc/shadow
# In docker we use jupyter notebook 5.4, however, in Singularity we
# can use the most recent version
/usr/local/bin/pip install -U --upgrade-strategy=eager notebook

%environment
unset XDG_RUNTIME_DIR

0 comments on commit a838adc

Please sign in to comment.