Restructure test suite and add file IO roundtrip tests #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scraps multi-dir discovery, improves code readability, and shortens a few filenames in the benchmark suite.
Most of these tests passed out of the box, except for CSV, which incurred some trouble with flattened contexts and quotechars. As a consequence, the CSV reader and writer get a small block of control flow, which JSON-loads the context and _contextkeys attributes if present, since Python-native CSV coerces everything to string. This requires some quotechar manipulation, and changing over the `_contextkeys` attribute to a list of strings instead of a tuple, since json.load cannot deal with round parentheses.
nicholasjng
force-pushed
the
restructure-tests
branch
from
2bc9242
to
d90d59a
Compare
|
For reviewers: Is it worth inferring the schema from the CSV records? Upside is type safety, downside is more (and potentially difficult) implementation necessary. Note that a user can plug in his |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scraps multi-dir discovery, improves code readability, and shortens a
few filenames in the benchmark suite.
Most of these tests passed out of the box, except for CSV, which incurred
some trouble with flattened contexts and quotechars.
As a consequence, the CSV reader and writer get a small block of control
flow, which JSON-loads the context and _contextkeys attributes if present,
since Python-native CSV coerces everything to string. This requires some
quotechar manipulation, and changing over the
_contextkeysattributeto a list of strings instead of a tuple, since json.load cannot deal with
round parentheses.