Add BQ example to showcase cloud streaming of benchmark records #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BQ example revealed that we cannot just store the keys as a property on our class, since they might not be digestible by a database if certain illegal characters are used. For BQ, this was the case with the default "." separator, which means we have to pipe the separator through in the `BenchmarkRecord.compact()` call. Hence, the context keys need to be fetched dynamically.
In this setup, we show how easy it is to stream records completely without a reporter by simply ingesting the JSON representations resulting from `BenchmarkRecord.compact()`. This might be the way forward for most of our examples in place of a dedicated reporter.
nicholasjng
force-pushed
the
add-bq-example
branch
from
01a49c0 to
1d8ce84
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this setup, we show how easy it is to stream records completely
without a reporter by simply ingesting the JSON representations resulting
from
BenchmarkRecord.compact().This might be the way forward for most of our examples in place of a
dedicated reporter.
Clean up mypy config to allow dupe filenames in examples/
< no message>
Make contextkeys() an API to handle separator properly
The BQ example revealed that we cannot just store the keys as a property
on our class, since they might not be digestible by a database if certain
illegal characters are used.
For BQ, this was the case with the default "." separator, which means we
have to pipe the separator through in the
BenchmarkRecord.compact()call. Hence, the context keys need to be fetched dynamically.
Closes #66.