Group context structs under top-level semantic keys #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of sticking the single keys into the top-level context struct, we group them under semantic keys in a lower nested level. This has the benefit that ambiguous keys like "version" or "commit" can be given for multiple context aspects, like Python vs. git vs. ... Changes the unit tests to operate on the nested structs instead.
Contains null-column filtering, a table format setter, a benchmark regex filter, and a context filter able to operate on nested values. This is especially important now that we pushed semantically related contexts one level up.
actions/cache to v4, actions/setup-python to v5,
actions.{up,down}load-artifact to v4. This is mostly to silence node16
upgrade warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sticking the single keys into the top-level context struct, we group them under semantic keys in a lower nested level. This has the benefit that ambiguous keys like "version" or "commit" can be given for multiple context aspects, like Python vs. git vs. ...
Changes the unit tests to operate on the nested structs instead.