Skip to content

Commit

Permalink
roachtest: route schema change workload flakes to foundations
Browse files Browse the repository at this point in the history
About once a week or so, some backup-restore roachtest flakes on the schema
change workload. This patch routes these flakes directly to foundations.

Epic: none

Release note: none
  • Loading branch information
msbutler committed Nov 25, 2024
1 parent a14cf66 commit 60e6b4b
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions pkg/cmd/roachtest/tests/backup_restore_roundtrip.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/util/hlc"
"github.com/cockroachdb/cockroach/pkg/util/randutil"
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
"github.com/cockroachdb/errors"
)

var (
Expand Down Expand Up @@ -250,7 +251,7 @@ func startBackgroundWorkloads(
}
err = c.RunE(ctx, option.WithNodes(workloadNode), scInit.String())
if err != nil {
return nil, err
return nil, registry.ErrorWithOwner(registry.OwnerSQLFoundations, errors.Wrapf(err, "failed to init schema change workload"))
}

run := func() (func(), error) {
Expand All @@ -267,7 +268,10 @@ func startBackgroundWorkloads(
return c.RunE(ctx, option.WithNodes(workloadNode), tpccRun.String())
})
stopSC := workloadWithCancel(m, func(ctx context.Context) error {
return c.RunE(ctx, option.WithNodes(workloadNode), scRun.String())
if err := c.RunE(ctx, option.WithNodes(workloadNode), scRun.String()); err != nil {
return registry.ErrorWithOwner(registry.OwnerSQLFoundations, errors.Wrapf(err, "failed to run schema change workload"))
}
return nil
})

stopSystemWriter := workloadWithCancel(m, func(ctx context.Context) error {
Expand Down

0 comments on commit 60e6b4b

Please sign in to comment.