Skip to content

Commit

Permalink
admission: turn on snapshot ingest bandwidth control by default
Browse files Browse the repository at this point in the history
With cockroachdb#133310 merged, and
promising results from internal experimentation, we can turn this
setting on by default.

Informs: cockroachdb#121779.

Release note (ops change):
`kvadmission.store.snapshot_ingest_bandwidth_control.enabled` is now
'true' by default. This will enable disk bandwdith based Admission
Control for range snapshot ingests. It requires the provisioned
bandwidth to be set using `kvadmission.store.provisioned_bandwidth`.
  • Loading branch information
aadityasondhi committed Dec 17, 2024
1 parent 76ed91e commit 52906f1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/util/admission/snapshot_queue.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ var snapshotWorkItemPool = sync.Pool{
var DiskBandwidthForSnapshotIngest = settings.RegisterBoolSetting(
settings.SystemOnly, "kvadmission.store.snapshot_ingest_bandwidth_control.enabled",
"if set to true, snapshot ingests will be subject to disk write control in AC",
// TODO(aaditya): Enable by default once enough experimentation is done.
metamorphic.ConstantWithTestBool("kvadmission.store.snapshot_ingest_bandwidth_control.enabled", false),
metamorphic.ConstantWithTestBool("kvadmission.store.snapshot_ingest_bandwidth_control.enabled", true),
settings.WithPublic,
)

Expand Down

0 comments on commit 52906f1

Please sign in to comment.