Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A custom workflow #6

Merged
merged 6 commits into from
Apr 4, 2021
Merged

A custom workflow #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be13344
add team notes on automation
hectorsector Sep 24, 2019
73070c4
bump node-forge
lmkeston Sep 21, 2020
eda7354
Merge main into team-workflow
github-learning-lab[bot] Apr 4, 2021
44e0418
Create approval-workflow.yml
aabueno Apr 4, 2021
ac76cac
Update .github/workflows/approval-workflow.yml
aabueno Apr 4, 2021
43148fe
Update .github/workflows/approval-workflow.yml
aabueno Apr 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/approval-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
name: Team awesome's approval workflow
aabueno marked this conversation as resolved.
Show resolved Hide resolved
on: pull_request_review
aabueno marked this conversation as resolved.
Show resolved Hide resolved
jobs:
labelWhenApproved:
runs-on: ubuntu-latest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 17: Hint

  1. Edit the workflow file on this branch.
  2. Give your step a name, have it use pullreminders/label-when-approved-action@main, and set all the required environment variables.
    Suggested change
    runs-on: ubuntu-latest
    runs-on: ubuntu-latest
    steps:
    - name: Label when approved
    uses: pullreminders/label-when-approved-action@master
    env:
    APPROVALS: "1"
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    ADD_LABEL: "approved"
  3. Commit your changes to this branch.

7 changes: 7 additions & 0 deletions automation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
The team would like:
- [ ] branch protections
- [ ] required review approvals
- [ ] easy way to see when enough approvals has been achieved
- [ ] matrix build
- [ ] save build artifacts
- [ ] dedicated test job