Improved library search algorithm #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael-bmec-co
approved these changes
May 7, 2020
Library and include names in some of the libraries differ, which prevented the toolchain in locating the library (issue #19). The improved algorithm introduces library indexer to index the available libraries, their names and includes, the library search algorithm utilizes this info during the search to fix the issue #19.
Internal target names of Arduino libraries are made consistent as there is now a possibility to use both the include as well as library names in target_link_arduino_libraries. This is to avoid multiple targets of the same library.
a9183756-gh
force-pushed
the
feat/lib_indexer
branch
from
f9c1f10 to
9160744
Compare
|
Thanks for verifying that it works for you. Fix is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library and include names in some of the libraries differ, which
prevented the toolchain in locating the library (issue #19). The
improved algorithm introduces library indexer to index the available
libraries, their names and includes, the library search algorithm
utilizes this info during the search to fix the issue #19.