Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure AD - improvements #34

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Add support for Azure AD - improvements #34

merged 1 commit into from
Jun 25, 2021

Conversation

ItalyPaleAle
Copy link
Contributor

Sorry for the follow-up PR, I realized I could have improved on #33 a bit:

  1. Use an interface for the SP provider object to avoid adding github.com/Azure/go-autorest/autorest/adal as a dependency to this module. So people who don't need to use Azure AD authentication don't need to import the entire package in their project
  2. Fixed test that was leftover from before.

Please let me know when you think you can make a new release too :)

Use an interface for the SP provider object to avoid adding "github.com/Azure/go-autorest/autorest/adal" as a dependency to this module
Also, fixed test that was leftover from before.
Improves upon #33
@a8m a8m merged commit 486191d into a8m:master Jun 25, 2021
@a8m
Copy link
Owner

a8m commented Jun 25, 2021

Thanks for your contribution @ItalyPaleAle. I actually prefer this approach.

Please let me know when you think you can make a new release too :)

I invited you as a collaborator for the project. Please let me know if you want to release this version and write a few notes about the new feature. Thanks 🙏

@ItalyPaleAle
Copy link
Contributor Author

Thank you @a8m for merging!

I am happy to share some proposed release notes:

Added the ability to authenticate with Cosmos DB using Azure AD and enable using RBAC; this is optimized for usage with an *adal.ServicePrincipalToken object (#33, #34). See the Cosmos DB documentation for and the example for usage with this library.

Thanks for the invite to the project too. I don't think I can commit to being a maintainer, I'm just a user and contributing when I can :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants