This repository has been archived by the owner on Mar 22, 2023. It is now read-only.
Build process for Gutenberg blocks #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved on Nov 16th meeting by majority. |
ahegyes
force-pushed
the
feat/gb-blocks-build
branch
from
beb1a75 to
55523c6
Compare
|
Approved by majority in meeting on Nov 16th. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
package.jsonDiscussion points
wp-scriptssupports an entry point with either one of the extensionsjs,jsx,ts, ortsxso I wanted to leave on block in vanilla JS and have on block in TS; however, while it would compile, TS wouldn't actually do any type checking because we would be missing thets-loaderin the bundled webpack config; I didn't want to add a custom webpack config for that, so it might be best to wait until this is officially supported; however, feel free to build complicated TypeScript-blocks with TS-style classes and all that -- compiling will work;