Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix revoke request parameter #141

Merged
merged 8 commits into from
Jun 27, 2022
Merged

🐛 Fix revoke request parameter #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3617e8d
Revoke authorization
Jun 18, 2022
5f57626
Update README
Jun 18, 2022
e37e84f
Merge branch 'A-Tokyo:main' into main
zicyApp Jun 21, 2022
51db8c1
Add support for access token revoke
Jun 21, 2022
eb8542b
Merge branch 'A-Tokyo:main' into main
zicyApp Jun 22, 2022
013ed9d
Update tests for revoke authorization
Jun 22, 2022
07731b1
Merge branch 'A-Tokyo:main' into main
zicyApp Jun 26, 2022
9872c5a
Fix revoke parameter name
Jun 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ const clientSecret = appleSignin.getClientSecret({
const options = {
clientID: 'com.company.app', // Apple Client ID
clientSecret,
tokenHintType: 'refresh_token'
tokenTypeHint: 'refresh_token'
};

try {
Expand All @@ -176,7 +176,7 @@ const clientSecret = appleSignin.getClientSecret({
const options = {
clientID: 'com.company.app', // Apple Client ID
clientSecret,
tokenHintType: 'access_token'
tokenTypeHint: 'access_token'
};

try {
Expand Down
6 changes: 3 additions & 3 deletions __tests__/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('test for each functions', () => {
const option = {
clientID: 'clientID',
clientSecret: 'clientSecret',
tokenHintType: 'refresh_token',
tokenTypeHint: 'refresh_token',
};
it('Should not throw error when response is empty', async () => {
const result = await appleSignin.revokeAuthorizationToken(token, option);
Expand All @@ -55,7 +55,7 @@ describe('test for each functions', () => {
const option = {
clientID: 'clientID',
clientSecret: 'clientSecret',
tokenHintType: 'refresh_token',
tokenTypeHint: 'refresh_token',
};
it('Should not throw error when response is empty', async () => {
const result = await appleSignin.getAuthorizationToken(code, option);
Expand All @@ -70,7 +70,7 @@ describe('test for each functions', () => {
const option = {
clientID: 'clientID',
clientSecret: 'clientSecret',
tokenHintType: 'refresh_token',
tokenTypeHint: 'refresh_token',
};
it('Should not throw error when response is empty', async () => {
const result = await appleSignin.refreshAuthorizationToken(
Expand Down
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ const revokeAuthorizationToken = async (
options: {
clientID: string,
clientSecret: string,
tokenHintType: 'refresh_token' | 'access_token',
tokenTypeHint: 'refresh_token' | 'access_token',
},
): Promise<any> => {
if (!options.clientID) {
Expand All @@ -289,7 +289,7 @@ const revokeAuthorizationToken = async (
params.append('client_id', options.clientID);
params.append('client_secret', options.clientSecret);
params.append('token', token);
params.append('token_hint_type', options.tokenHintType);
params.append('token_type_hint', options.tokenTypeHint);

const result = await fetch(url.toString(), {
method: 'POST',
Expand Down
2 changes: 1 addition & 1 deletion typescript/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ declare function revokeAuthorizationToken(
options: {
clientID: string;
clientSecret: string;
tokenHintType: 'refresh_token' | 'access_token';
tokenTypeHint: 'refresh_token' | 'access_token';
},
): Promise<any>;

Expand Down
6 changes: 3 additions & 3 deletions typescript/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,13 @@ async function test() {
refreshAuthorizationToken('');

// $ExpectType Promise<any>
revokeAuthorizationToken('', { clientID: '', clientSecret: '', tokenHintType: 'refresh_token' });
revokeAuthorizationToken('', { clientID: '', clientSecret: '', tokenTypeHint: 'refresh_token' });

// $ExpectType Promise<any>
revokeAuthorizationToken('', { clientID: '', clientSecret: '', tokenHintType: 'access_token' });
revokeAuthorizationToken('', { clientID: '', clientSecret: '', tokenTypeHint: 'access_token' });

// $ExpectError
revokeAuthorizationToken('', { clientID: '', clientSecret: '', tokenHintType: '' });
revokeAuthorizationToken('', { clientID: '', clientSecret: '', tokenTypeHint: '' });

// $ExpectError
revokeAuthorizationToken('', { clientID: '', clientSecret: '' });
Expand Down