Updated react-reconciler #44
Conversation
react-reconciler updated to support newest React.js features like React hooks for writing functional components.
| @@ -43,21 +42,6 @@ if (isProd) { | |||
| plugins.push(...[ | |||
| new webpack.optimize.ModuleConcatenationPlugin(), | |||
| new webpack.optimize.OccurrenceOrderPlugin(), | |||
| new UglifyJsPlugin({ | |||
There was a problem hiding this comment.
Any reasons to remove minification for production build?
There was a problem hiding this comment.
Because new version of UglifyJS no longer supports ES6 and actually Webpack minifies code automatically when its in production mode. Hence the
mode: isProd ? 'production' : 'development', 58th line
webpack.config.js
Outdated
| @@ -43,21 +42,6 @@ if (isProd) { | |||
| plugins.push(...[ | |||
| new webpack.optimize.ModuleConcatenationPlugin(), | |||
There was a problem hiding this comment.
According to mode documentation production mode already includes ModuleConcatenationPlugin and OccurrenceOrderPlugin
There was a problem hiding this comment.
Oh, I forgot about that, its the same case as in removing the UglifyJS then. I will remove it then.
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "tvdml", | |||
| "version": "6.2.3", | |||
| "version": "6.3.0", | |||
There was a problem hiding this comment.
Please rollback version value. Releases are made with CI and they use current value to bump version
There was a problem hiding this comment.
Of course, no problem. will do.
package-lock.json
Outdated
| @@ -0,0 +1,5962 @@ | |||
| { | |||
There was a problem hiding this comment.
Please delete package-lock.json because yarn is used as a default package manager
|
Also, please check the tests. they are failing to run. You can run them locally with |
Yeah, I see it, its just probably update from babel-register to @babel/register. I will check it all :-) |
|
Checked things regarding suspense. There are small changes to reconciler's config but everything should work except hiding elements which is not allowed in TVML. Will add these changes after merging this PR 👍 |
|
Ok, I updated webpack config, removed the package-lock and changed npm test script to include @babel/register not babel-register. Everything is passing now. Thank you for keeping this project going 💪 |
|
Published as |
Hi,
I have updated react-reconciler library to support newest React.js features like React hooks for writing functional components.
Also with that I updated all the bundling dependencies like babel and webpack to their newest versions.
Have a nice day!