Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option refactoring #75

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Option refactoring #75

merged 5 commits into from
Nov 22, 2023

Conversation

Minyewoo
Copy link
Collaborator

No description provided.

@Minyewoo Minyewoo linked an issue Oct 11, 2023 that may be closed by this pull request
@Minyewoo Minyewoo requested a review from a-givertzman October 11, 2023 10:43
Copy link
Owner

@a-givertzman a-givertzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested an example, please try to improve all tests for Option and Result

lib/src/core/option/option.dart Show resolved Hide resolved
test/unit/core/option/option_fold_test.dart Outdated Show resolved Hide resolved
test/unit/core/option/option_fold_test.dart Outdated Show resolved Hide resolved
@a-givertzman a-givertzman merged commit 8c5032e into master Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Option implementation
2 participants