Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local store tests #71

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Local store tests #71

merged 7 commits into from
Aug 29, 2023

Conversation

Minyewoo
Copy link
Collaborator

@Minyewoo Minyewoo commented Jun 5, 2023

No description provided.

@Minyewoo Minyewoo mentioned this pull request Jun 5, 2023
12 tasks
@Minyewoo Minyewoo linked an issue Jun 5, 2023 that may be closed by this pull request
12 tasks
@Minyewoo Minyewoo requested a review from a-givertzman June 21, 2023 10:40
a-givertzman
a-givertzman previously approved these changes Jun 21, 2023
for (final key in initialKeys) {
final result = await store.remove(key);
expect(result, isTrue);
currentLocalStoreValues.remove(key);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify that store returns empty string on removed key

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@a-givertzman a-givertzman merged commit 08e97db into master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests | fix code coverage issue
2 participants