Start a small test suite of OSM XML -> RawMap GeoJSON goldenfiles. #8 #15
Conversation
|
You can view the current output with github's viewer, https://github.com/a-b-street/osm2streets/blob/main/tests/src/aurora_sausage_link/output.json |
tests across larger chunks of OSM in a-b-street/osm2streets#15.
|
Thanks for CCing me in.
Can you keep me in the loop on those as well? |
|
@martinfleis, sure -- I added more in a few followup commits, all at https://github.com/a-b-street/osm2streets/tree/main/tests/src. If you come across any good examples in OSM, please send them over and we can add them here. When we actually start trying to simplify some of these scenarios, I can CC you on those PRs too |
| //! - `input.osm`, from the export tab of https://www.openstreetmap.org | ||
| //! - `cfg.json`, defining the `driving_side` and describing the situation | ||
| //! - `output.json`, a GeoJSON file showing the resulting road and intersection polygons |
There was a problem hiding this comment.
Can we call these test.json (or test.yml), input.osm, rawmap.geojson? I want to add tests of different kinds that sit along side the RawMap GeoJSON ones, so lets name each output what it is.
I might go for roads.dot (then corridors.dot)...
There was a problem hiding this comment.
Sure! So cfg.json -> test.json and output.json -> raw_map.geojson I think? I can work on that as well as adding docs how to use this sometime this week
See
src/lib.rsfor a description of what this does. In short, we can clip out a osm.xml file for some tricky area, run it through A/B Street's current code, and save the resulting polygons as geojson. As we iterate on that code, we can see when the output changes, making this a convenient regression test.I'm starting this code in this repo and not A/B Street to:
@BudgieInWA, there are many other ideas you mentioned in the issue -- consider this just a start.
CC @martinfleis, who has some Google summer of code students also working on street network simplification. At the very least, we could share the input test cases that cause problems. There are only 3 included in this PR so far, but I have many more in mind to add.