meter shows "finished trips vs baseline" instead of time #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
requested changes
Mar 15, 2021
| if app.has_prebaked().is_some() { | ||
| let now = self.time; | ||
| let mut baseline_finished = self.baseline_finished_trips.unwrap_or(0); | ||
| for (t, _, _, _) in &app.prebaked().finished_trips[baseline_finished..] { |
There was a problem hiding this comment.
Ahhh, clever trick. Most of the things that read Analytics recalculate everything from scratch constantly. To one day speed this up, I was imagining making some kind of stateful "cursor" objects to remember where a computation left off. But that's total overkill for something like this -- just remembering the count is much simpler.
game/src/sandbox/speed.rs
Outdated
| } | ||
|
|
||
| let text_geom = Text::from( | ||
| Line(format!("Finished Trips: {}", prettyprint_usize(finished),)).fg(text_color), |
There was a problem hiding this comment.
nit: stray comma inside the format macro
game/src/sandbox/speed.rs
Outdated
| let mut tooltip_text = Text::from(Line("Finished Trips")); | ||
| tooltip_text.add(Line(format!( | ||
| "{} ({}% of total)", | ||
| finished, |
There was a problem hiding this comment.
prettyprint_usize(finished)
game/src/sandbox/speed.rs
Outdated
| // TODO: up/down icons | ||
| let line = if baseline_finished > finished { | ||
| let difference = baseline_finished - finished; | ||
| Line(format!("{} less than baseline", difference)) |
There was a problem hiding this comment.
prettyprint_usize here and below, to help point out really dramatically high differences from the baseline
|
Ok, I believe I've responded to your feedback. PTAL @dabreegster |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trip_meter.mov.mp4
edge cases
next day
no prebaked day/night
no changes
