Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widening roads #597

Closed
dabreegster opened this issue Apr 8, 2021 · 3 comments
Closed

Widening roads #597

dabreegster opened this issue Apr 8, 2021 · 3 comments

Comments

@dabreegster
Copy link
Collaborator

Splitting out from #67 -- indeed the case of totally new roads is more complicated. First we'll just handle being able to change the total number of lanes in a road (often by converting one wide driving lane to two narrower cycle lanes, for example) and change individual lane widths.

All the notes in #67 still apply, but now that pathfinding is no longer a blocker, the next things I'm thinking about:

  • Adding a debug UI to edit all the lanes in a road by a string (like spd|dbs for [sidewalk, parking, driving, driving, bike, sidewalk]`). Yuwen is starting design work on a proper editing UI too.
  • The first steps to apply these edits... intersection geometry has to be recalculated, and that means recalculating draw_all_unzoomed_roads_and_intersections. We do that when we swap day/night colors, so I'm not as worried about it being slow.
  • Main uncertainty is about LaneIDs. Before, they're a fixed-size list. Now we can delete/add arbitrarily. Should we have Vec<Option<Lane>> and re-use old IDs when possible? This is a common problem in the Rust gaming world, and entity component systems all have a way of handling it. We're not going to pull in an entire ECS, but I'll look at how they internally manage these collections. I know slotmap is one common approach.
dabreegster added a commit that referenced this issue Apr 8, 2021
@dabreegster
Create a temporary dev-only UI for modifying the number of lanes in a…
ca4876d 
… road. #597

It crashes when actually trying to change the number of lanes, as
expected.
dabreegster added a commit that referenced this issue Apr 8, 2021
@dabreegster
Change Vec<Lane> to BTreeMap<LaneID, Lane> to prepare for
f017a51 
adding/deleting lanes. #597

Not regenerating all maps yet. Haven't evaluated performance impact yet.
dabreegster added a commit that referenced this issue Apr 8, 2021
@dabreegster
A humble start to deleting lanes. #597
df2c1f3
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Create a temporary dev-only UI for modifying the number of lanes in a…
e6d07d8 
… road. #597

It crashes when actually trying to change the number of lanes, as
expected.
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Change Vec<Lane> to BTreeMap<LaneID, Lane> to prepare for
979c853 
adding/deleting lanes. #597

Not regenerating all maps yet. Haven't evaluated performance impact yet.
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
A humble start to deleting lanes. #597
88d19ca
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Fix lane geometry after changing the number of lanes. #597
6448b6e
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Support adding lanes. #597
39c2cdc 
And in fact, unify the cases of deleting lanes, adding lanes, or just
modifying them in place.
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Actually, to keep all of the existing editing UIs from breaking, pres…
9cd365c 
…erve LaneIDs when just editing lane types. #597
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Use LaneSpec in map edits, letting width of each lane be modified too. …
8898daa 
…#597
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Create a temporary dev-only UI for modifying the number of lanes in a…
2a89b68 
… road. #597

It crashes when actually trying to change the number of lanes, as
expected.
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Change Vec<Lane> to BTreeMap<LaneID, Lane> to prepare for
c6906f6 
adding/deleting lanes. #597

Not regenerating all maps yet. Haven't evaluated performance impact yet.
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
A humble start to deleting lanes. #597
584c1be
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Fix lane geometry after changing the number of lanes. #597
14609ab
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Support adding lanes. #597
3beb153 
And in fact, unify the cases of deleting lanes, adding lanes, or just
modifying them in place.
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Actually, to keep all of the existing editing UIs from breaking, pres…
68661f0 
…erve LaneIDs when just editing lane types. #597
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Use LaneSpec in map edits, letting width of each lane be modified too. …
e8b7019 
…#597
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
Fix a crash where you edit one lane normally, then add/delete lanes o…
169d376 
…f the same road. #597
dabreegster added a commit that referenced this issue Apr 9, 2021
@dabreegster
The new intersection polygon usually changes the trimming of all conn…
71ffb87 
…ected road center lines. #597
dabreegster added a commit that referenced this issue Apr 10, 2021
@dabreegster
Recreate the road in the quadtree when modifying width. #597
c1fe509
dabreegster added a commit that referenced this issue Apr 10, 2021
@dabreegster
The new intersection polygon usually changes the trimming of all conn…
c16f185 
…ected road center lines. #597
dabreegster added a commit that referenced this issue Apr 10, 2021
@dabreegster
Recreate the road in the quadtree when modifying width. #597
6b30bff
dabreegster added a commit that referenced this issue Apr 12, 2021
@dabreegster
Repair building connections after road widening. #597
e8ff6c2 
Don't redraw the paths yet, or try to deal with failures to snap.
dabreegster added a commit that referenced this issue Apr 12, 2021
@dabreegster
Repair parking lot connections after road widening. #597
7fa75b5
dabreegster added a commit that referenced this issue Apr 13, 2021
@dabreegster
Repair building connections after road widening. #597
0b772bc 
Don't redraw the paths yet, or try to deal with failures to snap.
dabreegster added a commit that referenced this issue Apr 13, 2021
@dabreegster
Repair parking lot connections after road widening. #597
a7ad1ef
dabreegster added a commit that referenced this issue Apr 13, 2021
@dabreegster
Repair building connections after road widening. #597
a649e0b 
Don't redraw the paths yet, or try to deal with failures to snap.
dabreegster added a commit that referenced this issue Apr 13, 2021
@dabreegster
Repair parking lot connections after road widening. #597
9923c12
@dabreegster
Copy link
Collaborator Author

Just preserving some notes/ideas:

  • Even before we overhaul public transit, prevent edits near bus stops from crashing
  • Make Road store lanes_ltr: Vec<(LaneID, LaneSpec)> and refactor things like get_half_width
  • Prevent changing the number of lanes near borders? Think through what scenarios assume can be done there. (Or maybe some trips just start failing)
  • Consider a dramatic cleanup: just treat lanes as a view onto roads. LaneID becomes RoadID and an offset. The Lane struct all but goes away; instead map.get_l just returns something that has a reference to Road and the ability to shift center points over

dabreegster added a commit that referenced this issue Apr 17, 2021
@dabreegster
Handle adding/deleting sidewalks. This needs more caution at the path…
c1d95a2 
…finding layer. #597

Tested by adding a sidewalk to 28th and Madison in the Arboretum map.
Not regenerating maps yet.
dabreegster added a commit that referenced this issue May 18, 2021
@dabreegster
Create a UI to apply edits from one road to others with matching conf…
5e5cef8 
…igurations. #597
dabreegster added a commit that referenced this issue May 19, 2021
@dabreegster
Create a UI to apply edits from one road to others with matching conf…
a528409 
…igurations. #597
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Start to dismantle the old lane editor by moving the old bulk road
eed346e 
selector into debug mode. #597

Previously, it was used both to search/replace lane types and to
select roads, then dump them in various formats. Just preserve the
latter behavior.
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Add access restrictions button to new road editor. #597
486f1bb 
The design in Figma treats it like a dropdown, but I think we still need
the dedicated UI to draw the bounds of the access-restricted zone.
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Delete the old lane editor. Jump straight into the new road editor, f…
1c468e9 
…ocused on a particular lane. #597
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Clean up the old special case for editing just a single lane type. No…
7784e89 
…w, every modification to a road will touch LaneIDs. #597

This is safe to do, now that the two callers (the old lane editor, and
the old bulk lane type switcher) are gone.
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Enforce max 2 sidewalks and max 2 parking lanes per road. It was working
5161236 
for adding new lanes, but not changing existing lanes. #597
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Enforce parking lanes requiring a driving lane; the simulation crashe…
30de209 
…s otherwise. #597

The enforcement is a bit more invasive, because there's a few ways of
getting into a bad state.
@dabreegster dabreegster mentioned this issue May 21, 2021
Merged
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Start to dismantle the old lane editor by moving the old bulk road
a5ae881 
selector into debug mode. #597

Previously, it was used both to search/replace lane types and to
select roads, then dump them in various formats. Just preserve the
latter behavior.
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Add access restrictions button to new road editor. #597
548acc1 
The design in Figma treats it like a dropdown, but I think we still need
the dedicated UI to draw the bounds of the access-restricted zone.
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Delete the old lane editor. Jump straight into the new road editor, f…
256d280 
…ocused on a particular lane. #597
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Clean up the old special case for editing just a single lane type. No…
dc5a484 
…w, every modification to a road will touch LaneIDs. #597

This is safe to do, now that the two callers (the old lane editor, and
the old bulk lane type switcher) are gone.
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Enforce max 2 sidewalks and max 2 parking lanes per road. It was working
6449351 
for adding new lanes, but not changing existing lanes. #597
dabreegster added a commit that referenced this issue May 21, 2021
@dabreegster
Enforce parking lanes requiring a driving lane; the simulation crashe…
d7d45b9 
…s otherwise. #597

The enforcement is a bit more invasive, because there's a few ways of
getting into a bad state.
dabreegster added a commit that referenced this issue May 23, 2021
@dabreegster
Highlight the lane card when hovering on the lane in the map. #597
13bb434 
[rebuild] [release]
dabreegster added a commit that referenced this issue Jun 20, 2021
@dabreegster
Reset current selection after editing multiple roads. This sometimes …
e6e6fb2 
…crashes if the selected lane gets deleted or assigned a new ID. Fixes a crash trying to make the West Green Lake cycletrack. #597
dabreegster added a commit that referenced this issue Jun 20, 2021
@dabreegster
Make the multi-road editor only check and edit lanes_ltr, not speed l…
d8cdfab 
…imit. The Aurora cycletrack edit stopped matching because the speed limit happens to change along Aurora. We can think through a better UX to handle both, but I suspect most use cases will focus on lane configuration. #597
dabreegster added a commit that referenced this issue Jun 20, 2021
@dabreegster
Fix loading edits that change the number of lanes in a road. We need …
ae3d4e2 
…to compare the old version of the road in the edits with the basemap, NOT the edited version of the road. #597
dabreegster added a commit that referenced this issue Jun 20, 2021
@dabreegster
Fix the lane widths appearing the same in the dropdown due to rounding.
786bb11 
#597
dabreegster added a commit that referenced this issue Jul 6, 2021
@dabreegster
Add a revert button to the road editor. #597
fe49a09
dabreegster added a commit that referenced this issue Jul 16, 2021
@dabreegster
Consistently follow rules for whether a lane can be edited. #597
ff310af 
Allow sidewalks, shoulders, and center turn lanes to be edited now.
Still don't touch service roads or light rail.
dabreegster added a commit that referenced this issue Jul 23, 2021
@dabreegster
When you change a lane type, also adjust to the default width for the…
753a79a 
… new type. #597
@dabreegster dabreegster mentioned this issue Jul 23, 2021
Merged
dabreegster added a commit that referenced this issue Jul 25, 2021
@dabreegster
When you change a lane type, also adjust to the default width for the…
d03d1b1 
… new type. #597 (#714)
dabreegster added a commit that referenced this issue Aug 4, 2021
@dabreegster
Set the default width of a newly added lane better. #597
85b46e2
@dabreegster dabreegster mentioned this issue Sep 6, 2021
Merged
@dabreegster
Copy link
Collaborator Author

Screenshot from 2021-09-30 13-56-23
UX issue. When editing a road with only one or two lanes, the two lane cards stretch out quite a bit. They're still proportional to the lane width, but the cards just look odd being so stretched out.

@dabreegster
Copy link
Collaborator Author

New road editor has been live for ages, nothing actionable here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dabreegster