Cran comments #47
Merged
Cran comments #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-street#44 - added to project - added to Rbuildignore
Fix typo for vignettes folder name a-b-street#44
add new news for a-b-street#44
Add testing environments to cran-comments.md file
bump version by minor a-b-street#44
Robinlovelace
approved these changes
Aug 11, 2021
| @@ -9,3 +9,4 @@ | |||
| ^pkgdown$ | |||
| ^README\.Rmd$ | |||
| ^ab_scenario\.json$ | |||
| ^cran-comments\.md$ | |||
| @@ -1,7 +1,7 @@ | |||
| Type: Package | |||
| Package: abstr | |||
| Title: R Interface to the A/B Street Transport System Simulation Software | |||
| Version: 0.2.1 | |||
| Version: 0.3.0 | |||
| @@ -0,0 +1,2 @@ | |||
| *.html | |||
| *.R | |||
There was a problem hiding this comment.
Really? Why ignore all .R files?
There was a problem hiding this comment.
Only for vignette files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Robinlovelace this should cover the majority of prerequisites needed for cran submission, do we want to add any more documentation at this stage / is there anything I have missed?
I have made two issues #45 and #46 which look at adding LCID and a walkable city to the vignettes. Should these be part of the next release?