magefile:bugfix - fixing error with update version functions #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanmartinszup
requested review from
iancardosozup,
lucasbrunozup,
matheusalcantarazup and
wiliansilvazup
as code owners
nathanmartinszup
force-pushed
the
bugfix/magefile
branch
from
9e58b08
to
61b2898
Compare
For some reason both functions responsable for updating the project version stopped working. This pull request removes the update specific for json since the tool don't seens to work while being executed by mage. Also fixed an error in UpdateHorusecVersionInProject wich was reporting file not found. Now just this function will update all necessary files. Signed-off-by: Nathan Martins <[email protected]>
nathanmartinszup
force-pushed
the
bugfix/magefile
branch
from
61b2898
to
18a8825
Compare
iancardosozup
approved these changes
Feb 3, 2022
wiliansilvazup
approved these changes
Feb 3, 2022
nathanmartinszup
added a commit
that referenced
this pull request
Feb 3, 2022
For some reason both functions responsable for updating the project version stopped working. This pull request removes the update specific for json since the tool don't seens to work while being executed by mage. Also fixed an error in UpdateHorusecVersionInProject wich was reporting file not found. Now just this function will update all necessary files. Signed-off-by: Nathan Martins <[email protected]> (cherry picked from commit a6859ae)
wiliansilvazup
pushed a commit
to wiliansilvazup/horusec-platform
that referenced
this pull request
Feb 23, 2022
For some reason both functions responsable for updating the project version stopped working. This pull request removes the update specific for json since the tool don't seens to work while being executed by mage. Also fixed an error in UpdateHorusecVersionInProject wich was reporting file not found. Now just this function will update all necessary files. Signed-off-by: Nathan Martins <[email protected]> (cherry picked from commit a6859ae) Signed-off-by: Wilian Gabriel <[email protected]>
nathanmartinszup
added a commit
that referenced
this pull request
Mar 7, 2022
For some reason both functions responsable for updating the project version stopped working. This pull request removes the update specific for json since the tool don't seens to work while being executed by mage. Also fixed an error in UpdateHorusecVersionInProject wich was reporting file not found. Now just this function will update all necessary files. Signed-off-by: Nathan Martins <[email protected]> (cherry picked from commit a6859ae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason both functions responsable for updating the project
version stopped working. This pull request removes the update specific for
json since the tool don't seens to work while being executed by mage.
Also fixed an error in UpdateHorusecVersionInProject wich was reporting
file not found. Now just this function will update all necessary files.
Signed-off-by: Nathan Martins [email protected]
- What I did
- How to verify it
- Description for the changelog