This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
routed
column onv2deployments
table on each reconcile loop.If all desired components+circles are found on the observed state we set the column to true.
To make it easier to perform de "diff" of the observed stated and desired state I introduced a new annotation to the VirtualService and DestinationRule manifests.
Since the annotation fields can only be a key/value pair of strings we have to json encode the circle id list to a string, and decode it when reading the field. This will also be relevant when discussing a future feature to add user defined metadata to the deployments.