Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Add infinite scroll in Workspace #906

Merged
merged 60 commits into from
Mar 1, 2021
Merged

Conversation

luanecavalcantizup
Copy link
Contributor

@luanecavalcantizup luanecavalcantizup commented Feb 11, 2021

UI module

  • move workspaces listing to menu
  • add infinite scroll to workspaces listing

Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
@boring-cyborg boring-cyborg bot added the ui Improvements/additions/fixes for ui module. label Feb 11, 2021
@luanecavalcantizup luanecavalcantizup self-assigned this Feb 11, 2021
Signed-off-by: luanecavalcantizup <[email protected]>
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #906 (2b0b387) into main (eab0c32) will increase coverage by 0.05%.
The diff coverage is 82.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #906      +/-   ##
============================================
+ Coverage     77.14%   77.19%   +0.05%     
  Complexity     1978     1978              
============================================
  Files          1207     1207              
  Lines         16610    16638      +28     
  Branches       1520     1522       +2     
============================================
+ Hits          12814    12844      +30     
+ Misses         3314     3312       -2     
  Partials        482      482              
Flag Coverage Δ Complexity Δ
moove 74.07% <ø> (ø) 0.00 <ø> (ø)
ui 79.71% <82.89%> (+0.10%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
ui/src/modules/Workspaces/Menu/MenuItem.tsx 92.30% <ø> (ø) 0.00 <0.00> (ø)
ui/src/core/providers/workspace.ts 85.00% <50.00%> (+0.78%) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/index.tsx 73.91% <70.58%> (-21.93%) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/Menu/index.tsx 82.92% <82.05%> (+4.66%) 0.00 <0.00> (ø)
ui/src/modules/Users/hooks.ts 87.73% <100.00%> (+2.44%) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/Menu/Loaders/index.tsx 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/Menu/Loaders/list.tsx 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/Menu/styled.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/hooks.ts 80.00% <100.00%> (+1.05%) 0.00 <0.00> (ø)
ui/src/modules/Workspaces/state/actions.ts 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab0c32...5debe05. Read the comment docs.

@boring-cyborg boring-cyborg bot added the moove Improvements/additions/fixes for moove module. label Feb 17, 2021
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
luanecavalcantizup and others added 8 commits February 23, 2021 10:10
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
Signed-off-by: luanecavalcantizup <[email protected]>
ifdouglas
ifdouglas previously approved these changes Feb 24, 2021
Leandroqo
Leandroqo previously approved these changes Feb 24, 2021
Leandroqo
Leandroqo previously approved these changes Feb 26, 2021
emiteze
emiteze previously approved these changes Feb 26, 2021
Copy link
Contributor

@emiteze emiteze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back approved

@luanecavalcantizup luanecavalcantizup dismissed stale reviews from emiteze and Leandroqo via cf5f82b February 26, 2021 16:51
Copy link
Contributor

@emiteze emiteze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back approved

@monicaribeiro monicaribeiro merged commit c01dd4f into main Mar 1, 2021
@monicaribeiro monicaribeiro deleted the workspace-infinite-scroll branch March 1, 2021 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
moove Improvements/additions/fixes for moove module. TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants