This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
adding deployment active on patch workspace to remove deployment config #1243
Merged
barbararochazup
merged 5 commits into
charlescd-release-1.0.0
from
hotfix/patch-workspace-deployment-config
May 17, 2021
Merged
adding deployment active on patch workspace to remove deployment config #1243
barbararochazup
merged 5 commits into
charlescd-release-1.0.0
from
hotfix/patch-workspace-deployment-config
May 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: barbararochazup <[email protected]>
Signed-off-by: barbararochazup <[email protected]>
Codecov Report
@@ Coverage Diff @@
## charlescd-release-1.0.0 #1243 +/- ##
=============================================================
+ Coverage 76.85% 76.92% +0.06%
- Complexity 2185 2203 +18
=============================================================
Files 1309 1309
Lines 18751 18789 +38
Branches 1707 1713 +6
=============================================================
+ Hits 14412 14454 +42
+ Misses 3832 3829 -3
+ Partials 507 506 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: barbararochazup <[email protected]>
emiteze
suggested changes
May 17, 2021
...rc/main/kotlin/io/charlescd/moove/application/workspace/impl/PatchWorkspaceInteractorImpl.kt
Show resolved
Hide resolved
...rc/main/kotlin/io/charlescd/moove/application/workspace/impl/PatchWorkspaceInteractorImpl.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: barbararochazup <[email protected]>
Signed-off-by: barbararochazup <[email protected]>
emiteze
approved these changes
May 17, 2021
lucasbfernandes
approved these changes
May 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: barbararochazup [email protected]
Issue Description
Adding validation to patch workspace when remove a configuration id to not remove when have a active deployment