Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

chore: adjust report to sonarqube #44

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

uziassantosferreira
Copy link
Contributor

Related Issues

Closes ZupIT/beagle#1790

Description and Example

coverage was not sending the correct report to Sonarqube with this code, everything has been fixed

Screen Shot 2021-12-04 at 16 51 14

Checklist

Please, check if these important points are met using [x]:

  • I read the PR Guide and followed the process outlined there for submitting this PR.
  • I avoided breaking changes by not changing public APIs that people rely on.
  • I am willing to follow-up on review comments in a timely manner.
  • I have made the documentation changes or I created an issue explaining how to document this change on Docs issues. Please link the issue here:

@uziassantosferreira
Copy link
Contributor Author

i need help with this issue of the license in the header i put the correct date but it keeps failing, it would be interesting to put settings for intelij to create these files with the correct header that would help the developer.

@uziassantosferreira
Copy link
Contributor Author

is there any reason for external contributions the jobs not run? these mistakes about secrets is on your side I can't do anything on my side

@hectorcustodiozup
Copy link
Contributor

hectorcustodiozup commented Dec 6, 2021

Hi @uziassantosferreira, thank you for you interest in contributing with Beagle.

I will take a look into it as soon as possible, the token secrets seemed to be ignored when repositories are forked, the license header is an internal tool of ours.

I am editing my message on the header license error:
The header should follow the pattern "Copyright startingYear, currenteYear..." in your case 2020, 2021 should fix the issue. But indeed the error alert could be improved and so I am opening a request of enhancement for the owners.

@uziassantosferreira
Copy link
Contributor Author

@hectorcustodiozup but I change all files I created to 2021 and the error still happens x.x

@hectorcustodiozup
Copy link
Contributor

@hectorcustodiozup but I change all files I created to 2021 and the error still happens x.x

Yes, but the copyrights requests initial and final years, so, as I left in my comment for your case the correct copyright is Copyright 2020, 2021 ...

Signed-off-by: uziassantosferreira <[email protected]>
@uziassantosferreira
Copy link
Contributor Author

@hectorcustodiozup thanks I fixed

@uziassantosferreira
Copy link
Contributor Author

@hectorcustodiozup can you see this PR <3

@hectorcustodiozup
Copy link
Contributor

Hi @uziassantosferreira,

We are currently working on some other demands but we are aware of your pull request and will soon be tested and reviewed.

Thanks

@hectorcustodiozup hectorcustodiozup merged commit 634f162 into ZupIT:main Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend] Coverage not working
2 participants