Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#985: Introduce PygameSilent #988

Closed
wants to merge 1 commit into from
Closed

Conversation

Julian-O
Copy link
Contributor

Resolution to #985.

Uses new package, pygamesilent, to import pygame without dumping the "Hello" message to stdio.

(Fix for Coverage<5.0 is also included here - see separate pull request, #987.)

  • If this is a bugfix, I have provided code that clearly demonstrates the problem and that works when used with this PR

See #985 for failing code. See new test for succeeding code.

  • I have added a test to the test suite, if necessary

Note it is skipped in Travis because, at time of writing, no Travis tests run while Pygame is installed. It has been run manually.

  • I have properly documented new or changed features in the documention, or the docstrings
  • I have properly documented unusual changes to the code in the comments around it
  • I have made note of any breaking/backwards incompatible changes

- Specify in setup.
- Mention in readme.
- Modify all imports (3 places)
- Modify error messages if imports missing.
- Add test.

(Fix for Coverage<5.0 is also included here - see separate pull request.)
@Julian-O
Copy link
Contributor Author

Julian-O commented Jul 17, 2019

One of the Travis build jobs has apparently failed with an intermittent issue with apt-get - nothing to do with my change. Could a maintainer please restart the build, so the checks will pass?

@CanadaHonk
Copy link

I suggest just using:

os.environ['PYGAME_HIDE_SUPPORT_PROMPT'] = "hide"

Or something similar instead of having to rely on an entire other package which acts as middleware.

@tburrows13
Copy link
Collaborator

Closed as #1017 has been merged.

@tburrows13 tburrows13 closed this Feb 22, 2020
@tburrows13 tburrows13 added lib-misc Issues pertaining to misc. 3rd-party libraries. bug-fix For PRs and issues solving bugs. lib-Pygame Issues pertaining to dependency Pygame. labels Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PRs and issues solving bugs. lib-misc Issues pertaining to misc. 3rd-party libraries. lib-Pygame Issues pertaining to dependency Pygame.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants