Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #120, should tools.is_string function work identically between py2 and py3? #475

Closed
wants to merge 16 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Mar 9, 2017

No description provided.

* add coveralls to travis.yml

* add coveralls python module

* add pytest-cov python module

* add pytest-cov python module

* add pytest-cov python module

* add coverage

* modify .coverage

* travis

* remove coverage

* remove coverage

* remove coverage

* remove coverage

* remove coverage

* remove coverage

* remove coverage

* remove coverage

* remove coverage

* remove coverage

* remove coverage

* remove coverage

* __init__.py needed for pytest-cov and coverage to play nicely

* change concatenation to concatenate_videoclips

*  test tools
@ghost ghost mentioned this pull request Mar 9, 2017
@coveralls
Copy link

coveralls commented Mar 9, 2017

Coverage Status

Coverage remained the same at 38.049% when pulling 82225e8 on earney:issue_120 into 11de2a6 on Zulko:master.

@mbeacom mbeacom added this to the Release v0.2.3.2 milestone Apr 5, 2017
@mbeacom
Copy link
Collaborator

mbeacom commented Apr 13, 2017

@Earney Re-assigning this to the v0.2.3.3 release.

@ghost ghost added the python-version Compatibility issues, behaviour changes,... between different Python versions. label Apr 13, 2017
@coveralls
Copy link

coveralls commented Apr 14, 2017

Coverage Status

Coverage increased (+15.8%) to 53.819% when pulling 330d177 on earney:issue_120 into 11de2a6 on Zulko:master.

@tburrows13 tburrows13 changed the title Issue 120, should tools.is_string function work identically between py2 and py3? Issue #120, should tools.is_string function work identically between py2 and py3? Apr 15, 2020
@tburrows13
Copy link
Collaborator

No longer needed due to removal of support for Py2.7.

@tburrows13 tburrows13 closed this Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python-version Compatibility issues, behaviour changes,... between different Python versions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants