Support improved syntax for all effects in editor.py #1104
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, certain effects were being added as methods to VideoClips and AudioClips. This makes the syntax for using them much easier, however, not all effects were included in this. Seeing as the list of effects are already generated in
moviepy/video/fx/all/__init__.py
andmoviepy/audio/fx/all/__init__.py
(imported intoeditor.py
asvfx
andafx
respectively), it made sense to instead use these lists instead.Note that there is no such list for
transfx
(which are just the contents ofmoviepy/video/compositing/transitions.py
so this is still just manually implemented).