update for button component #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
culas
approved these changes
Aug 9, 2024
r3dDoX
reviewed
Sep 3, 2024
| @@ -123,7 +123,7 @@ export default class Button extends BaseElement { | |||
| } | |||
|
|
|||
| private get buttonSpacing(): ButtonSpacing { | |||
| if (this.type === 'icon-only') { | |||
| if (this.type === 'icon-only' && this.spacing === 'text') { | |||
There was a problem hiding this comment.
Not sure if I understand this change. What's the use case for type 'icon-only' but spacing 'text'?
There was a problem hiding this comment.
Can't fully remember, it's a change we did in the project (last October 😉). As far as I understand it, the type "icon-only" should only affect spacing if that has not been set explicitly, which would mean something else than "text" as that's the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update button component