Bench mark report #280
Merged
Bench mark report #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/openapi3.yaml # src/tests/models/database/cassandra/cassandraConnector.js # src/tests/models/manager.js # src/tests/routes/testsRoute.js # tests/integration-tests/tests/tests-test.js # tests/unit-tests/tests/models/manager-test.js
# Conflicts: # docs/devguide/docs/swagger-docs.yaml # docs/openapi3.yaml # src/database/cassandra-handler/init-scripts/18__bench_mark_data_tests.cql # src/reports/models/database/cassandra/cassandraConnector.js # src/tests/controllers/testsController.js # src/tests/models/database.js # src/tests/models/database/cassandra/cassandraConnector.js # src/tests/models/manager.js # src/tests/routes/testsRoute.js
enudler
reviewed
Apr 6, 2020
src/database/cassandra-handler/init-scripts/19__bench_mark_data_reports.cql
Outdated
Show resolved
Hide resolved
enudler
reviewed
Apr 6, 2020
enudler
reviewed
Apr 6, 2020
enudler
reviewed
Apr 6, 2020
enudler
reviewed
Apr 6, 2020
enudler
reviewed
Apr 6, 2020
enudler
reviewed
Apr 6, 2020
enudler
reviewed
Apr 6, 2020
src/reports/models/reportsManager.js
Outdated
| if (testBenchMarkData) { | ||
| const reportAggregate = await aggregateReportManager.aggregateReport(report); | ||
| const reportBenchMark = benchmarkCalculator.calculate(testBenchMarkData, reportAggregate.aggregate); | ||
| const { data, score } = reportBenchMark; |
There was a problem hiding this comment.
benchmarkCalculator.calculate returns data, but data is the input
need to change that.
i would suggest the function
benchmarkCalculator.calculate will be called benchmarkCalculator.calculateReportScore and return number
There was a problem hiding this comment.
it was only temp, it will return the score, and data is the way we got to this score it will not be the same data as input
enudler
reviewed
Apr 6, 2020
enudler
reviewed
Apr 6, 2020
docs/openapi3.yaml
Outdated
| @@ -215,7 +215,6 @@ paths: | |||
| application/json: | |||
| schema: | |||
| $ref: '#/components/schemas/error_response' | |||
| # Tests | |||
enudler
reviewed
Apr 6, 2020
enudler
reviewed
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.