-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rtsp #615
Rtsp #615
Conversation
commit 97ee989 fixes the last item identified in #612. @connortechnology Can you test your camera on this pr? My Foscam 9821 now works perfectly, with no warnings. I have two additional cameras I plan to test as well. |
Apparently the custom "split" function found in zm_utils.cpp does not return anything if it does not find the split character. I need to push a small change this evening to account for that.
|
Um, in regards to the split function... seems like it should, perhaps we need to fix that... and test to make sure it hasn't been causing other problems. |
Tested, works good. |
I'm happy to merge if you want me to. Would like to see this split issue addressed sometime in future though, but that's not really anything to do with this PR. |
Let me look into the split function situation tonight. I need to test against some live equipment, which I am not set up to do here at my dayjob. If this is the case with the split function, that means there is a bug in the handling of the ffmpeg & libvlc options. One would currently need to have at least two options in order for either option to take effect. This might explain why I've never noticed any extra output coming from ffmpeg after adding loglevel=debug to the options field. |
I ran a couple tests on the split function last night, and it appears I was mistaken. |
Rtsp Conflicts: src/zm_rtsp.cpp
Fixes three of the items identified in #612.