Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please update bundled jQuery #785

Closed
onlyjob opened this issue Apr 5, 2015 · 8 comments
Closed

please update bundled jQuery #785

onlyjob opened this issue Apr 5, 2015 · 8 comments

Comments

@onlyjob
Copy link
Contributor

onlyjob commented Apr 5, 2015

Let's upgrade jquery from v1.4.2 to 1.7.2 please.
1.7.2 is the version that soon to-be-released Debian Jessie is shipping.
Official Debian packaging of Zoneminder uses system (not bundled) version of jquery.

I'm not sure if code changes will be needed but new version appears to be backwards compatible. Thanks.

@knight-of-ni
Copy link
Member

I think I want to let @kylejohnson respond to this.
I see on the jquery site that there are many versions to choose from. Do you have a problem with upgrading to 1.7.2?

@onlyjob
Copy link
Contributor Author

onlyjob commented Apr 12, 2015

As far as I can tell jQuery 1.7.2 works just fine in Zoneminder. In fact I've never used Zoneminder with older bundled jQuery 1.4.2... I'm all for conservative upgrade, not to the latest version but to the well tested 1.7.2 for now.

@knight-of-ni
Copy link
Member

I noticed the new API Kyle is working on has some references to jquery in it. I want make sure it doesn't affect that.

@kylejohnson
Copy link
Member

Any reason not to use the latest 1.11.2 version?
The API should not be affected at all.

onlyjob added a commit to onlyjob/ZoneMinder that referenced this issue Apr 15, 2015
@onlyjob
Copy link
Contributor Author

onlyjob commented Apr 15, 2015

It is good to know that jQuery maintains stable API.
Zoneminder users in Debian rely on system jQuery (and therefore will not benefit from upgrade of a bundled jQuery). At this time Debian ship libjs-jquery/1.7.2 so naturally Zoneminder will be used with this particular version. I suggest upgrading to this particular version because it is the most tested one.

Please remember to create un-versioned symlink jquery.js --> jquery-1.7.2.js and update reference in skins/classic/includes/export_functions.php -- this will simplify future upgrades.

Also please never ever commit minified javascripts. They are same as pre-compiled binaries -- unreadable, unmodifiable, and non-distributable in Debian.

@onlyjob
Copy link
Contributor Author

onlyjob commented Apr 15, 2015

See #809

knight-of-ni pushed a commit that referenced this issue Apr 15, 2015
upgrade bundled jQuery (Closes: #785)
@onlyjob
Copy link
Contributor Author

onlyjob commented Apr 16, 2015

All good (merged), closing...

@onlyjob onlyjob closed this as completed Apr 16, 2015
@onlyjob
Copy link
Contributor Author

onlyjob commented Apr 24, 2015

@kylejohnson FYI JQuery web site says:

The jQuery 1.x line had major changes as of jQuery 1.9.0. We strongly recommend that you also use the jQuery Migrate plugin if you are upgrading from pre-1.9 versions of jQuery or need to use plugins that haven't yet been updated. Read the jQuery 1.9 Upgrade Guide and the jQuery 1.9 release blog post for more information.

I reckon we'll need more caution to upgrade to jQuery v1.9.0 and above...

This was referenced Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants