Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

remove is default from vote_proposal #92

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

dimiandre
Copy link
Contributor

fix indexing of vote_proposal transactions

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@neithanmo neithanmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, can you elaborate on why the vote_dafault was removed? does it follow a new namada version?

@dimiandre
Copy link
Contributor Author

dimiandre commented Feb 5, 2024

looks good to me, can you elaborate on why the vote_dafault was removed? does it follow a new namada version?

Yes it's not present anymore in namada sdk

pub struct VoteProposalData {
    /// The proposal id
    pub id: u64,
    /// The proposal vote
    pub vote: ProposalVote,
    /// The proposal voter address
    pub voter: Address,
    /// Validators to who the voter has delegations to
    pub delegations: Vec<Address>,
} 

and it's causing node to not sync up because of table error

ERROR namadexer::indexer: Closing block producer task due to an error saving last block: Database error: error returned from database: INSERT has more expressions than target columns

am i wrong @rllola ?

@rllola
Copy link
Contributor

rllola commented Feb 5, 2024

Yes that's the fix. Thank you @dimiandre.
I had to skip the tests in my last PR because my node wouldn't sync and I couldn't generate new blocks... So I missed it.

@rllola rllola merged commit 6706265 into Zondax:main Feb 5, 2024
5 of 6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants