Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

fix transaction by hash and other improvements #74

Merged
merged 6 commits into from
Dec 29, 2023
Merged

fix transaction by hash and other improvements #74

merged 6 commits into from
Dec 29, 2023

Conversation

neithanmo
Copy link
Collaborator

This:

  • Fixes error when querying transactions by hash
  • improve docs for new endpoints
  • use the Rust option type for types that are set only if transaction type is a Wrapper
  • move query string construction to its module to improve readability

@neithanmo neithanmo mentioned this pull request Dec 27, 2023
Closed
emmanuelm41
emmanuelm41 reviewed Dec 28, 2023
View reviewed changes
src/server/endpoints/transaction.rs
@@ -15,7 +15,7 @@ pub async fn get_tx_by_hash(
State(state): State<ServerState>,
Path(hash): Path<String>,
) -> Result<Json<Option<TxInfo>>, Error> {
info!("calling /tx/:tx_hash");
info!("calling /tx/:tx_hash{}", hash);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add a space here?

@rllola rllola merged commit 0a870b6 into main Dec 29, 2023
5 checks passed
@rllola rllola deleted the fix/tx_by_hash branch December 29, 2023 07:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emmanuelm41 emmanuelm41 emmanuelm41 approved these changes

@rllola rllola rllola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neithanmo @rllola @emmanuelm41