This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
feat: improvements api #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
neithanmo
approved these changes
Oct 30, 2023
neithanmo
approved these changes
Oct 30, 2023
| @@ -1051,7 +1051,7 @@ impl Database { | |||
| /// Returns all the tx hashes for a block | |||
| pub async fn get_tx_hashes_block(&self, hash: &[u8]) -> Result<Vec<Row>, Error> { | |||
| // query for all tx hash that are in a block identified by the block_id | |||
| let str = format!("SELECT t.hash FROM {0}.{BLOCKS_TABLE_NAME} b JOIN {0}.{TX_TABLE_NAME} t ON b.block_id = t.block_id WHERE b.block_id =$1;", self.network); | |||
| let str = format!("SELECT t.hash, t.tx_type FROM {0}.{BLOCKS_TABLE_NAME} b JOIN {0}.{TX_TABLE_NAME} t ON b.block_id = t.block_id WHERE b.block_id = $1;", self.network); | |||
There was a problem hiding this comment.
@rllola I made this change, maybe you have something different in mind, with this change the function returns a row with two columns, the tx_hash, and tx_type.
There was a problem hiding this comment.
Yeah good catch looks like I missed it.
rllola
pushed a commit
that referenced
this pull request
Oct 31, 2023
This: - fix benches(outdated code) - improve our testing to ensure a fresh database is used, similar to benches to be merged after #45
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #37
This PR had the tx_type info to the block answer and add wrapper_id info for decrypted tx.