Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

fix: serialize tx_hashes as hex for json response #30

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

rllola
Copy link
Contributor

@rllola rllola commented Oct 17, 2023

closes #22

@bengtlofgren
Copy link
Contributor

These changes are incompatible with the MakeFile. Consider changing the config/Settings.example.toml -> config/Settings.toml or change the MakeFile

@bengtlofgren
Copy link
Contributor

bengtlofgren commented Oct 23, 2023

Also on line src/indexer/mod.rs:143 you want to change let fmt_addr = "{}:{} ..." -> let fmt_addr = format!("http://{}:{}", config.tendermint_addr, config.port); or you will get connection issues.

EDIT: I now see this was changed in an older PR. A comment would be very helpful.

@Fraccaman
Copy link
Contributor

you can look at this commit, we just fixed it in our hermes fork: https://github.com/heliaxdev/hermes/commit/9835e7491c9742ff72e10fff01a69f6f3bcff5a2

@rllola rllola merged commit 5947a48 into main Oct 24, 2023
5 checks passed
@rllola rllola deleted the fix/tx-id-format branch October 24, 2023 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elements in tx_hashes list should be formatted
3 participants