This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Update views tx_vote_proposal and tx_transfer #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I may have made things difficult by not removing a former commit, not sure if that's problematic for revision history, not sure how to fix that. Lmk if needs changing |
rllola
approved these changes
Apr 9, 2024
|
There is no conflict so we should be good. |
|
I see there's a build failing in checks, but not familiar enough with process to know if significant. |
|
Don't worry it is earthly. It is part of our devops process and it is not required. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The views tx_vote_proposal and tx_transfer took in all transactions regardless of status (failed/succeeded). Updated views to only use successful transactions, as in former version tables. Note: An alternate approach might be to make the views richer and include fail/success status in tables. For now this is a quick fix.
(I assume this may be an issue with the other views as well, but not familiar enough with the data to fix atm. I have validated the data from this particular fix against former databases and seen that it's better corresponding)