This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Do not set INDEXER_CONFIG_PATH by default in Dockerfile #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I considered also removing the default |
|
Yeah sure @joel-u410 we can remove it. |
|
ok @rllola -- I'll push another commit to this branch for that. |
rllola
approved these changes
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the docker image to be configured via env variables instead of a config file. (When
INDEXER_CONFIG_PATHis set, the application will only use the file and will not attempt to read its config from env vars.) This is useful for environments like Google Cloud Run where it is simpler to set env vars than to mount a file into the container.